lzungri opened a new issue, #2568:
URL: https://github.com/apache/nuttx-apps/issues/2568

   ### Description / Steps to reproduce the issue
   
   If a PPP peer disconnects and then tries to reconnect it will send an `'LCP 
configure request'` packet. The code that handles that scenario seems to be 
clearing the wrong `lcp_state` flag (`LCP_RX_UP` instead of `LCP_TX_UP`) and 
thus the nuttx ppp client will keep sending IPCP packets which are rightfully 
dropped by the new peer since it is still in the LCP negotiation phase.
   
   Consider replacing this code:
   ```
   ctx->lcp_state &= ~LCP_RX_UP;
   ```
   
   with:
   ```
   ctx->lcp_state &= ~LCP_TX_UP;
   ```
   
   Source here: 
https://github.com/apache/nuttx-apps/blob/1f51bfe64dfa931d97137b0c7561c053e1d6078d/netutils/pppd/lcp.c#L138
   
   I can create a PR if that helps.
   
   ### On which OS does this issue occur?
   
   [Linux]
   
   ### What is the version of your OS?
   
   Ubuntu
   
   ### NuttX Version
   
   12.6
   
   ### Issue Architecture
   
   [all]
   
   ### Issue Area
   
   [Networking]
   
   ### Verification
   
   - [X] I have verified before submitting the report.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to