patacongo commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442867753
##########
File path: sched/Kconfig
##########
@@ -975,7 +975,7 @@ config SCHED_INSTRUMENTATION_SPINLOCKS
config SCHED_INSTRUMENTATION_SYSCALL
bool "System call monitor hooks"
default n
- depends on LIB_SYSCALL && ARCH_HAVE_SYSCALL_HOOKS
+ depends on ARCH_HAVE_SYSCALL_HOOKS
Review comment:
This seems incorrect. It should not be possible to enable syscall
instrumentation hooks if system calls are not enabled. The option should never
be visible to the user if it does not function.
Please revert to the original version or provide explanation. If
CONFIG_LIB_SYSCALL is not selected, then CONFIG_INSTRUMENTATION_SYSCALL must
not be selectable or visiable to the user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
