JianyuWang0623 commented on PR #13516: URL: https://github.com/apache/nuttx/pull/13516#issuecomment-2356614520
> If this is part of [apache/nuttx-apps#2579](https://github.com/apache/nuttx-apps/pull/2579) this commit would better fit there to have all changes in a single PR. But I guess this PR was created in order to fix build of 2579? > > Thanks for the testing example - in this case it would be also good to also show what happens before change in addition to showing what happens after change, that way we can exactly see where is the problem at first glance :-) > > Lets see what Ci says here. In general we can accept changes only if they pass CI in one place. Also out project is quite above the CI quota so we need to converse use a bit :D > > Thanks @JianyuWang0623 :-) Without this patch but with https://github.com/apache/nuttx-apps/pull/2579, e.g. `sim:sotest` ``` $ make distclean $ ./tools/configure.sh -l sim:sotest $ make savedefconfig $ diff defconfig boards/sim/sim/sim/configs/sotest/defconfig 22a23 > CONFIG_EXAMPLES_SOTEST_DEVMINOR=3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
