lupyuen commented on PR #13513: URL: https://github.com/apache/nuttx/pull/13513#issuecomment-2357574660
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests) This Pull Request seems **incomplete** based on the provided template. Here's a breakdown of what's missing and why it's important: **Summary** * **Missing:** * **Why is this change necessary?** Is it a bug fix, a performance improvement, a new feature request? * **What functional part of the code is being changed?** Be specific about the files/modules affected. * **How does the change work?** Provide a technical explanation of the implementation. **Impact** * **Potentially Inaccurate:** While marking all impacts as "NONE" might be accurate, it's unusual for a change to have absolutely zero impact. Double-check each point carefully. If there truly are no impacts, consider adding a brief explanation to "Anything else to consider" to confirm this. **Testing** * **Insufficient:** * **CI-CHECK is not enough.** Local testing is crucial. You must provide details about your build host (OS, CPU, compiler) and the target(s) you tested on (architecture, board, configuration). * **Logs are missing.** "Testing logs before change" and "Testing logs after change" sections are empty. Include relevant log snippets that demonstrate the issue before your change and the successful outcome after. **General Recommendations** * **Elaborate on "BCH: Add readonly configuration for BCH devices."** This is too brief. Clearly state the goal of adding this configuration option. What problem does it solve, or what new capability does it provide? * **Link to related resources.** If this PR addresses a specific issue or builds upon another PR, provide links for context. * **Proofread carefully.** Clear and accurate communication is essential for maintainers to review and merge your PR. **In short, before submitting this PR:** 1. **Complete the missing information** in the Summary, Impact, and Testing sections. 2. **Review the template carefully** to ensure you've addressed all points. 3. **Provide specific details** to help reviewers understand and evaluate your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
