xiaoxiang781216 commented on pull request #1271: URL: https://github.com/apache/incubator-nuttx/pull/1271#issuecomment-647004200
> A different thought: > > Currently the logic generates stubs that: > > ``` > call sched_note_syscall_enter() > Perform the system call > call sched_not_syscall_leave() > ``` > > These are apparently generated by tools/mksyscall.c. There are potentially hundreds for system call stubs, but on 7 system call functions for 0 through 6 parameters. Would it make more sense to put the instrumentation in those 7 system call functions rather than in the hundreds of system call stubs? Yes, it's a good idea, but we need find a solution when syscall isn't enabled. If syscall trace can't work with this case, this feature lose the most value because 99% project don't enable syscall at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
