lupyuen commented on PR #13536: URL: https://github.com/apache/nuttx/pull/13536#issuecomment-2359946315
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of *why* this change is necessary. Is it a bug fix? A feature request? Provide context. * "uorb info call" is too specific. What is the broader functional area impacted (e.g., logging, debugging, data formatting)? * **Impact:** * While you state "None," you need to address *all* impact points. Even if the answer is "NO," explicitly state it for clarity. * Your provided code snippet seems like it belongs in the "Testing" section. * **Testing:** * **Insufficient detail:** * You need to list the specific host operating systems, CPUs, compilers, target architectures, and boards you used for testing. * Provide *actual* testing logs, not just placeholders. * **Unclear what is being tested:** The code snippet is not self-explanatory. Describe the test case and expected results both before and after your change. **Recommendations:** 1. **Expand the Summary:** Explain the motivation for adding `%pB`. Is there a specific use case or issue it solves? 2. **Complete the Impact Section:** Even if the impact is minimal, go through each point and confirm its status. 3. **Provide Detailed Testing Information:** * List all relevant host and target configurations used. * Include complete testing logs demonstrating the issue *before* your change and the successful outcome *after*. * Clearly explain the purpose of your test code and the expected results. By addressing these points, your PR will be more informative and likely to be reviewed and merged more quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
