lupyuen commented on PR #13537: URL: https://github.com/apache/nuttx/pull/13537#issuecomment-2360087081
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests) No, this PR does not meet the NuttX requirements. Here's why and what's missing: * **Insufficient Summary:** * The summary provides the error message but lacks context. * **What change is being made to address the "unused function" error?** Is the function being removed, or is its functionality now needed? * **Why was this change necessary?** Was it a simple cleanup, or did it fix a bug? * **What part of the code is affected?** Specify it's related to SDIO functionality within the MMC/SD driver. * **Incomplete Impact:** * **Impact on user:** Even if the change seems internal, mention if users might see any differences (e.g., improved SDIO reliability). * **Impact on hardware:** Specify which architectures or boards that use SDIO are affected. * **Impact on documentation:** If the change impacts user-facing behavior, documentation might need updating. * **Missing Testing Details:** * **Build Host(s):** Provide details about the operating system, CPU architecture, and compiler used for building NuttX. * **Target(s):** Specify the target architecture (e.g., ARM, RISC-V) and the specific board and configuration used for testing. * **Testing logs:** Instead of just stating "ci test," provide relevant snippets of the build logs (before and after the change) that demonstrate the error and its resolution. **To improve this PR:** 1. **Expand the Summary:** Clearly explain the purpose of the change, the specific code affected, and why the change was needed. 2. **Complete the Impact Analysis:** Think through potential user, hardware, and documentation impacts. Be specific about which parts of NuttX are affected. 3. **Provide Detailed Testing Information:** Share the build host and target environments used. Include relevant log snippets showcasing the error before the fix and the successful build after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
