nuttxpr commented on PR #13550: URL: https://github.com/apache/nuttx/pull/13550#issuecomment-2362897308
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests) The PR summary is missing key information like: * **Why is this change necessary?** What problem does it solve? Is there a bug report or feature request driving this? * **What functional part of the code is being changed?** Be specific - mention files, modules, or functions affected. * **How does the change work?** Provide a more technical explanation of the implementation. The Impact section is somewhat vague: * **Is new feature added? Is existing feature changed?** Be explicit. This seems like a new feature, state that clearly. * **Impact on user:** "Provide universal mac addresses support" is not descriptive enough. How will users benefit? Will they need to change configurations, use new APIs, etc.? The Testing section needs significant improvement: * **Build Host(s):** Provide specific details about your development environment (OS version, compiler version, etc.). * **Testing logs before change / after change:** These are placeholders. You need to include **actual** log snippets demonstrating the issue before the change and the improvement after. **In its current state, the PR would likely not meet NuttX requirements.** You need to provide more context, details about the implementation, and clear evidence of testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
