nuttxpr commented on PR #13557: URL: https://github.com/apache/nuttx/pull/13557#issuecomment-2363318871
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The provided PR information does **not** meet the NuttX requirements. Here's why: * **Missing Essential Information:** The "Summary" section lacks details about the actual changes being made. It only states "No" without any context. * **Incomplete Impact Assessment:** Simply stating "No" for each impact category is insufficient. The PR needs to explicitly address how the change might affect users, builds, hardware, documentation, security, compatibility, etc. If there's truly no impact in a particular area, a brief explanation is still helpful (e.g., "Impact on build: NO - This change only affects application code and does not modify the build system"). * **Absent Testing Data:** The "Testing" section needs to provide concrete evidence that the changes work as expected. This includes: * Specifying the build host and target environments used for testing. * Including relevant testing logs from *before* and *after* the changes. **In short, a PR needs to clearly articulate what's being changed, why it's necessary, how it was tested, and what potential impact it might have on the NuttX ecosystem.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
