jlaitine commented on PR #11498: URL: https://github.com/apache/nuttx/pull/11498#issuecomment-2365005284
Hi all, @xiaoxiang781216 @acassis @jerpelea I just came accross this PR while trying to update the nuttx. Sorry to rant afterwards, I never noticed this before. This change just breaks all my configurations, and I think is wrong in many aspects - This is conceptually wrong. NSH is an application, a shell (or a combined shell and busybox kind of app...). NSH should reside ON the file ROMFS filesystem. In the end, you don't really want to "mount the romdisk from the NSH" nor even use the NSH as an "sbin/init" app (even though this is what is currently being done) - If we want a "common" mounting mechanism for "root" fs, we should have a separate simplified "init" in the kernel and NOT use NSH as an init process. You may just refer to other OSs (like linux). They are not using a shell to mount the root file system. This just doesn't make any sense! - There was no issues previously. You can just call "romdisk_register" and mount the (sbin) from your board initialization code For sure we could adapt to this change, but I feel that it is taking us, and the role of the NSH application into a wrong direction. I strongly suggest re-considering this approach, for now I am just reverting this change in our own branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
