nuttxpr commented on PR #13573: URL: https://github.com/apache/nuttx/pull/13573#issuecomment-2367120115
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirements Review While the provided information gives a basic idea, it **does not fully meet** the NuttX PR requirements. Here's a breakdown: **Summary:** * **Needs Improvement:** * **Why is this change necessary?** Is it fixing a bug? Improving consistency? * **What functional part is changed?** Be specific. "fs/chmod/fchmod/lchmod" is a start, but what exactly within them? * **How does it work?** What did these functions do before, and what do they do now? Just stating "ignore other bits" is vague without context. **Impact:** * **Incomplete:** You've left all impact sections blank. Even if you believe the impact is minimal, state it explicitly (e.g., "Impact on build: NO"). Address each point, justifying your answer. **Testing:** * **Insufficient:** * **Build Host(s):** Provide details about your development environment. * **Target(s):** On what hardware/simulator did you test? Be specific about architecture, board, and configuration. * **Testing logs:** The provided logs are very minimal. Show both the *commands used* and their *full output* before and after the change. Demonstrate how the change affects file mode bits specifically. **To improve this PR:** 1. **Expand the Summary:** Provide a clear and concise explanation of the problem, the solution, and the technical details of the change. 2. **Complete the Impact assessment:** Address each point, even if the answer is "NO". Justify your responses, especially if there's any potential impact. 3. **Provide detailed testing information:** Clearly document your build environment, target platform, and provide comprehensive testing logs that showcase the change's effect. By addressing these points, you'll create a much stronger PR that is easier for reviewers to understand and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
