nuttxpr commented on PR #13575: URL: https://github.com/apache/nuttx/pull/13575#issuecomment-2367182327
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX Requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why the change is necessary. Is it a bug fix, code cleanup, performance improvement, etc.? * Needs more details on how the change works. Simply stating that a structure is being moved is insufficient. Explain the reasoning and implications. * **Impact:** * While marking all sections as "N/A" might be technically correct, it's crucial to elaborate and justify why there's no impact in any area. For instance, even moving a structure could have implications on backward compatibility. * **Testing:** * "Local compile" is insufficient testing. Provide specific details: * Build Host(s) OS, CPU architecture, compiler version. * Target(s): Architecture (e.g., simulator, real hardware), board, configuration. * Include relevant testing logs *before* and *after* the change to demonstrate the problem being solved or the functionality being added. **Recommendations:** 1. **Expand the Summary:** Explain the motivation for the change and its technical details comprehensively. 2. **Address Impact Carefully:** Even if there's no apparent impact, explain why. For example, "This change only affects internal code structure and has no impact on the public API, build process, or hardware compatibility." 3. **Provide Detailed Testing Information:** List specific build hosts and targets, and include relevant log snippets to demonstrate the change's effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
