cederom commented on PR #2595: URL: https://github.com/apache/nuttx-apps/pull/2595#issuecomment-2367203428
> FYI @cederom I was able to reproduce the [accept4 build error](https://github.com/apache/nuttx-apps/actions/runs/10973134118/job/30470198826) on macOS Arm64 14.6.1 (23G93): > > ``` > $ tools/configure.sh bl602evb:wifi > $ make -j > CC: nettest_server.c > nettest_server.c:152:2: warning: NOT_APPLE //// [-W#warnings] > 152 | #warning NOT_APPLE //// > | ^ > nettest_server.c:153:14: error: call to undeclared function 'accept4'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 153 | acceptsd = accept4(listensd, (struct sockaddr *)&myaddr, &addrlen, > | ^ > nettest_server.c:153:14: note: did you mean 'accept'? > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/socket.h:708:9: note: 'accept' declared here > 708 | int accept(int, struct sockaddr * __restrict, socklen_t * __restrict) > | ^ > nettest_server.c:154:22: error: use of undeclared identifier 'SOCK_CLOEXEC' > 154 | SOCK_CLOEXEC); > | ^ > ``` > > And accept4 doesn't exist in MacOSX.sdk/usr/include/sys/socket.h Thank you @lupyuen !! :-) So this check was done without the fallback wrap `__APPLE__` and with the fallback all builds fine? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
