nuttxpr commented on PR #13577: URL: https://github.com/apache/nuttx/pull/13577#issuecomment-2367217052
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to mostly meet the NuttX requirements, but some areas could be clarified: **Strengths:** * **Summary:** Clearly explains the "why" (optimization, AOSP compatibility) and the "what" (header file cleanup, AOSP build). The "how" could be slightly more detailed, but the overall purpose is understandable. * **Impact:** Addresses most points well. The impact on users, build process, documentation, and compatibility needs more elaboration. **Areas for Improvement:** * **Impact (User):** Will any application developers using NuttX's libc need to make changes due to this optimization? Be specific if "YES". * **Impact (Build):** How does including libc parts in AOSP affect the NuttX build itself? Is this purely for AOSP usage, or are there NuttX build system changes too? * **Impact (Documentation):** Does this require documentation updates? If so, are they included in the PR or planned separately? * **Impact (Compatibility):** Mentioning "backward/forward/interoperability" is good, but provide specifics. Does this affect compatibility with *any* existing NuttX code, or only if someone tries to use the AOSP-built library in a specific way? * **Testing:** * **Host:** Specify the OS, CPU architecture, and compiler used for testing. * **Target:** "Vela" is a board, but mention the architecture (likely ARM). Also, specify the NuttX configuration used (e.g., `vela:nsh`). * **Logs:** While "works as intended" is a start, provide *some* evidence. This could be: * Successful build logs (at least showing no new warnings/errors in relevant areas). * Output from a test program using the optimized libc functions, demonstrating they behave the same before and after the change. **Conciseness:** The PR description is fairly concise. Focus on adding the missing specifics without making it overly verbose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
