nuttxpr commented on PR #13580: URL: https://github.com/apache/nuttx/pull/13580#issuecomment-2367749997
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, the provided PR summary does not meet the NuttX requirements.** **Missing Information:** * **Detailed explanation of changes:** * **Why** are these changes necessary? (e.g., bug fix, new hardware support, performance improvement) * **What** functional part of the code is being changed? (Be specific – mention the exact files and functions) * **How** do the changes work? (Provide a technical explanation of the implementation) * **Impact assessment:** * The "Impact" section is entirely empty. You **must** address each impact category (user, build, hardware, documentation, security, compatibility) and explain if/how your changes affect them. * **Testing details:** * **Insufficient testing information:** You need to provide: * Specific build host details (OS, CPU, compiler version) * Specific target details (architecture, board, configuration) * **Actual testing logs** (both before and after the change) to demonstrate the issue and the fix. **Example of an Improved Summary:** ## Summary This PR introduces support for 64-bit PCI I/O access and legacy interrupt routing on x86_64, along with ARMv7a PCI interrupt support. * **Motivation:** Many modern peripherals require 64-bit I/O access for optimal performance. Legacy interrupt routing is necessary for compatibility with older devices. ARMv7a support requires specific interrupt handling. * **Changes:** * **pci:** Added `pci_read_io_qword` and `pci_write_io_qword` functions for 64-bit access. Implemented legacy IRQ/MIS/MIX interface. * **arch/x86_64/src/x86_64_pci.c:** Implemented `x86_64_pci_read/write_io` functions to support 64-bit operations. * **arch/arm/src/armv7a:** Added PCI interrupt handling logic. * **Related Issues:** [Link to NuttX issue if applicable] **Remember to complete the "Impact" and "Testing" sections with detailed information.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
