xiaoxiang781216 commented on PR #13567: URL: https://github.com/apache/nuttx/pull/13567#issuecomment-2369908632
> > @anchao should we close this pr? > > I don't agree with exporting some functions from NuttX, which will make the nuttx to the restrictions of other OS build systems(Android). Don't you think this implementation is unreasonable? Do all future changes to libc functions need to be compiled through android before they could be merged? The reason I think this patch is good isn't the above statement, but because lzf is an optional component, stream.h don't include this header file st all if CONFIG_LIBC_LZF isn't enabled, the similar checking already exists near this change: ://github.com/apache/nuttx/pull/13567/files#diff-2dd8bd975a0b4fe946a837961405b253a447eb9822e8e9a4b43359aeea2b0188R32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
