pussuw commented on code in PR #13579:
URL: https://github.com/apache/nuttx/pull/13579#discussion_r1776019299
##########
binfmt/libelf/libelf_load.c:
##########
@@ -193,6 +270,23 @@ static inline int elf_loadfile(FAR struct elf_loadinfo_s
*loadinfo)
{
FAR Elf_Shdr *shdr = &loadinfo->shdr[i];
+ /* SHF_ALLOC indicates that the section requires memory during
+ * execution.
+ */
+
+ if ((shdr->sh_flags & SHF_ALLOC) == 0)
Review Comment:
Why is this tested twice ? Again on line 311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
