Otpvondoiats commented on PR #13536: URL: https://github.com/apache/nuttx/pull/13536#issuecomment-2376182474
> > > > > > @yamt please review the new implementation which disable the extension by default. > > > > > > > > > > > > > > > i feel it's difficult to use a kconfig which alters the behavior of very basic things like printf. when you want to enable it, you need to audit every uses of printf family functions in your system. > > > > > isn't it simper to provide an alternative api, say, nuttx_printf, to provide the extension? (similarly to linux printk) > > > > > > > > > > > > It requires changing all kernel caller, which is a huge change. The current solution already reduces the possibility of confliction as small as possible. > > > > > > > > > no. you only need to use the new interface when you actually use %pB etc, which i suppose very rare. > > > > > > @yamt hi, Can it be merged? > > i'm 对 it. Thanks for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
