nuttxpr commented on PR #13640: URL: https://github.com/apache/nuttx/pull/13640#issuecomment-2376560503
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** Here's why and what needs improvement: * **Insufficient Summary:** * **Missing "Why":** You haven't explained *why* changing the SMP startup from serial to parallel is necessary. What problem does it solve? What are the benefits (e.g., performance improvement)? * **Lack of Detail:** "changing the startup" is very vague. Be specific about what code is modified and how the parallel startup mechanism works. * **Missing References:** Are there related issues in the NuttX or NuttX Apps repositories? * **Incomplete Impact Assessment:** * **Limited Scope:** Simply stating "arm64" doesn't provide enough information. Specify the impact on: * **Architectures:** Does this *only* affect arm64? * **Boards:** Are any specific boards affected more than others? * **Drivers:** Are there driver implications? * **Missing Details:** You need to address all other impact points (user impact, build process, documentation, security, compatibility). Even if the answer is "NO," state it explicitly. * **Inadequate Testing:** * **Vague Host/Target:** "ostest" is not descriptive enough. Provide details about: * **Build Host:** Your operating system, CPU architecture, compiler version. * **Target:** The specific ARM64 architecture, board, and configuration you tested on. * **Missing Logs:** You need to include actual testing logs from *before* and *after* your changes. This demonstrates how the change works and helps reviewers verify its correctness. **To improve your PR:** 1. **Expand your Summary:** Provide a clear and concise explanation of the change's purpose, functionality, and any relevant issue references. 2. **Complete the Impact Assessment:** Address all impact points with specific details, even if the impact is minimal or non-existent. 3. **Provide Detailed Testing Information:** Include your build host and target details along with actual testing logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
