nuttxpr commented on PR #13643: URL: https://github.com/apache/nuttx/pull/13643#issuecomment-2376671902
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to **mostly meet** the NuttX requirements, but could use some improvements: **Strengths:** * **Summary:** Provides a clear description of the change (adding `adc_receive_batch`), its purpose (efficiency improvement for `adc_dma`), and the technical approach (single `memcpy` instead of looping). * **Impact:** Addresses most impact areas, highlighting the positive impact on build time and providing a good explanation of the efficiency gains. **Areas for Improvement:** * **Summary:** * **Issue References:** Include any related NuttX issues or pull requests. Even if there isn't a directly linked issue, mentioning any related discussions or previous attempts to address similar problems can be helpful. * **Impact:** * **User Impact:** While you mention time savings, specify if there are any user-facing API changes that might require code modifications. * **Hardware Impact:** Be specific about which architectures, boards, or drivers are affected by this change. Even if the answer is "none," it's good to state it explicitly. * **Documentation:** If this change introduces a new function or modifies existing behavior, documentation updates are essential. Briefly describe the updates or confirm that documentation is not needed. * **Testing:** * **Incomplete:** The "Testing" section is empty. * **Provide Details:** * List the specific build hosts and target platforms you used for testing. Include operating systems, architectures, compilers, and board configurations. * Include relevant snippets of testing logs that demonstrate the change's behavior before and after your modifications. Focus on logs related to the `adc_dma` functionality and time measurements. **Example Testing Section Improvements:** ``` ## Testing I confirm that changes are verified on the following setup and work as intended: * **Build Host:** Linux (Ubuntu 20.04), x86_64, GCC 9.4.0 * **Target:** STM32F4 Discovery board, adc_dma driver **Testing logs before change:** ``` [ADC DMA] Transferring 1024 samples (looping method) [ADC DMA] Time taken: 12.5 ms ``` **Testing logs after change:** ``` [ADC DMA] Transferring 1024 samples (batch memcpy) [ADC DMA] Time taken: 4.8 ms ``` ``` By adding specific details and testing results, your PR will be clearer, easier to review, and more likely to be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
