pussuw commented on PR #13886: URL: https://github.com/apache/nuttx/pull/13886#issuecomment-2400179901
> > Isn't up_cpu_index the _logical_ core number (which is only meaningful to the NuttX kernel), not the physical core number? I presume for AMP communication you need the physical core. > > Yes, that's why we have two api now: this_cpu and up_cpu_index. this_cpu is logical core number, up_cpu_index is physical core number. up_cpu_index always return the real core number regardless CONFIG_SMP setting, on the other hand this_cpu always return 0 if CONFIG_SMP is false after this patch: #13211 This makes sense, but the function description of up_cpu_index is still talking about SMP / logical CPU number, you need to update that too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
