nuttxpr commented on PR #13947: URL: https://github.com/apache/nuttx/pull/13947#issuecomment-2400261392
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Let's break down this PR against the NuttX requirements: **Meets Requirements?** Likely **NO**, but it needs more information. **Here's Why and What's Missing:** * **Summary:** * **Good:** It clearly states the change (handling multiple 'address & size' cells in device trees). * **Missing:** * **Necessity:** *Why* was this change necessary? Was the existing code broken? Did a new device driver need this functionality? * **Functional Part:** Be more specific. Is this in the device driver framework? The device tree parser itself? * **Issue References:** Are there any related issues in the NuttX or NuttX Apps repositories? This helps with tracking and context. * **Impact:** * **Too Vague:** "fdt, new API" doesn't tell us enough. * **Needs Details:** * **New Feature:** Since it's a new API, this is likely YES. Briefly explain what the new API allows developers to do. * **User Impact:** Will users of the device tree framework need to modify their code? If so, how? * **Hardware Impact:** Are there specific architectures or boards affected? * **Documentation:** Does this new API need to be documented? If so, has documentation been added/updated in the PR? * **Consider:** Think about potential side effects. Could this change break existing drivers that rely on the old behavior? * **Testing:** * **Insufficient:** "vela qemu" is not enough detail. * **Provide:** * **Build Host Details:** Which OS, compiler, and versions were used for testing? * **Target Details:** Be specific about the QEMU architecture and board configuration you tested with. * **Logs (Important!):** * **Before Change:** Show logs demonstrating the issue or limitation the PR addresses. * **After Change:** Show logs demonstrating the issue is resolved or the new functionality works. **How to Improve the PR:** 1. **Expand the Summary:** Explain the "why" and provide context. 2. **Detailed Impact Assessment:** Go through each impact point with specifics. 3. **Thorough Testing Information:** Provide build details, target details, and the essential before/after logs. By addressing these points, your PR will be much stronger and easier for the NuttX maintainers to review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
