yamt commented on a change in pull request #1280:
URL: https://github.com/apache/incubator-nuttx/pull/1280#discussion_r445968651
##########
File path: include/stdio.h
##########
@@ -225,6 +216,49 @@ FILE *popen(FAR const char *command, FAR const char *mode);
int pclose(FILE *stream);
#endif
+/* These APIs are not implemented and/or can be synthesized from
+ * supported APIs.
+ */
+
+#ifdef CONFIG_HAVE_INLINE
+static inline int putc(int c, FAR FILE *s)
Review comment:
i prefer to have less #ifdef CONFIG_xxx.
my suggestion (not to use inline or macro) is consistent with the other
functions.
inlined things are minority.
i can argue the 3rd part library is not totally standard-conforming as
standards allow these functions to be implemented as macros.
they even suggest the #undef tricks. see APPLICATION USAGE in
https://pubs.opengroup.org/onlinepubs/9699919799/functions/getc.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
