nuttxpr commented on PR #13965: URL: https://github.com/apache/nuttx/pull/13965#issuecomment-2401475127
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * **Why** is the change necessary? What problem does it solve? * **What** exactly is being changed? Be specific about the gcov configuration name and the "non-existent dependency." * **How** does the change work? * **Impact:** * While you mark most as "No," you **must** provide details if a change *does* impact users, builds, hardware, documentation, security, or compatibility. Don't just assume "No" is sufficient. * **Testing:** * **"No" is not acceptable.** You **must** provide testing logs to demonstrate the change's functionality. Include: * Specific build hosts and target environments used * Clear "before" and "after" logs showing the problem and the solution **Example of Improved Summary:** "This PR addresses an issue where the gcov configuration was incorrectly named 'xyz' instead of 'abc', causing build failures. Additionally, a non-existent dependency on library 'def' has been removed from the Makefile to streamline the build process." **Remember:** A good PR is detailed, provides context, and offers evidence of testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
