nuttxpr commented on PR #13968: URL: https://github.com/apache/nuttx/pull/13968#issuecomment-2401526629
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears **incomplete** based on the NuttX requirements. Here's why: * **Summary Lacks Detail:** * "sim bug fix" is too vague. Be specific about *what* bug is fixed and *how* it's fixed in each commit. * Provide a brief explanation of what functional areas are affected (e.g., watchdog timer, memory management, UART driver). * **Impact Is Under-Described:** * **RELEASE** suggests this is a critical bug fix. Provide specific details about the impact: * What breaks without this fix? * What are the consequences of the bugs being fixed? * While CI testing is good, it's not sufficient. You **must** provide: * **Build Host Information:** Your OS, compiler, etc. * **Target Details:** Which simulator configurations did you test (e.g., `sim:nsh`)? * **Testing Logs:** "Before" and "after" logs are essential to demonstrate the fix. **Recommendation:** Expand on the provided information to meet the NuttX PR requirements for a thorough review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
