nuttxpr commented on PR #13969: URL: https://github.com/apache/nuttx/pull/13969#issuecomment-2401661850
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears **incomplete** based on the provided NuttX requirements. **Here's why:** * **Summary:** * Lacks a clear explanation of *why* CRC-8-ROHC support is being added. What problem does it solve? What is its use case? * "libc: add CRC-8-ROHC support" is more of a title than a summary. * **Impact:** * While marking all as "none" might be accurate, it's best to provide brief justifications. For instance, "Impact on the user: None, as this is a new function added to libc and doesn't modify existing behavior." * **Testing:** * "sim" is too vague. Specify the simulator used (e.g., qemu-system-riscv32). * **Crucially,** the testing logs sections are empty. You **must** provide logs demonstrating the functionality before and after your change. This is essential for reviewers to understand what changed and verify its correctness. **To improve this PR:** 1. **Expand the Summary:** Explain the rationale behind adding CRC-8-ROHC. 2. **Elaborate on Impact (even if "none"):** Briefly justify why each impact category is marked as "none." 3. **Provide Detailed Testing Information:** * Specify the exact simulator used. * **Include actual testing logs** showing the behavior before and after your code change. Addressing these points will make your PR much stronger and increase the chances of it being reviewed and merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
