nuttxpr commented on PR #13981: URL: https://github.com/apache/nuttx/pull/13981#issuecomment-2401721890
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, the PR does not meet all NuttX requirements.** Here's why and how to improve it: * **Summary:** * **Insufficient detail:** The summary briefly describes the change but lacks context. Explain *why* the current non-blocking approach is problematic and *what benefits* changing it brings. * **Missing references:** Include links to related NuttX issues or pull requests if applicable. * **Impact:** * **Incomplete sections:** You only listed "rpmsg dev" under Impact. Address *all* impact categories: * **Is new feature added? Is existing feature changed?** (Yes, existing rpmsg dev functionality) * **User impact?** (Will applications using rpmsg need adjustments?) * **Build impact?** (Unlikely, but state it explicitly) * **Hardware impact?** (Unlikely, but be explicit) * **Documentation impact?** (Likely needs an update to reflect the change) * **Security impact?** (Consider potential implications of changing blocking behavior) * **Compatibility impact?** (Will this break existing rpmsg client applications?) * **Justify "YES" responses:** For any "YES" impact, provide details. For example, if there's a compatibility concern, explain what might break and how to mitigate it. * **Testing:** * **Insufficient information:** * **Host details are vague:** Specify the exact OS, CPU architecture, compiler version, etc., used for building. * **Target details are missing:** Provide the specific architectures and boards you tested on (e.g., `sim:qemu-rv32`, `arm:stm32f4discovery`). * **Logs are placeholders:** Include *actual* log snippets demonstrating the issue before and the improvement after your change. Highlight relevant sections. **To improve the PR:** 1. **Expand the summary:** Provide more context, explain the benefits of the change, and link to related issues/PRs. 2. **Complete the Impact section:** Address all categories, and provide specific details for any "YES" responses. 3. **Provide detailed testing information:** Specify your build host and target environments precisely. Include relevant log snippets that showcase the issue and the improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
