nuttxpr commented on PR #13985: URL: https://github.com/apache/nuttx/pull/13985#issuecomment-2401818129
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR appears to mostly meet NuttX requirements, however, there are some areas that need improvement: **Summary:** * **Needs more detail:** While it lists the files changed and provides a brief description, it lacks a clear explanation of *why* these changes are necessary. * Are these bug fixes? Performance improvements? New features? * What problems did the original code have? * How do these changes solve those problems? * **Missing issue references:** Are there any related NuttX issues this PR addresses? If so, they should be linked here. **Impact:** * **Too brief:** Simply stating "arm64" is insufficient. * **Specificity is key:** Which specific aspects of arm64 are impacted? * **User impact:** Will this change how users interact with arm64 systems? * **Build system:** Any changes to the build process? * **Documentation:** Does this PR require documentation updates? If so, were they provided? * **Address all points:** The template asks about security, compatibility, etc. Even if the answer is "NO", it should be stated explicitly for clarity. **Testing:** * **Insufficient detail:** * **Host details:** What OS, CPU architecture, and compiler version were used for testing? * **Target details:** Which specific "xiaomi armv8r board" was used? Provide the model. * **Log snippets:** Instead of just stating "qemu-armv8a:nsh", include relevant snippets from the logs demonstrating the issue *before* and the fix *after* the change. **Recommendations:** 1. **Expand the Summary:** Clearly articulate the "why" behind the changes. 2. **Provide Specific Impact Details:** Address all the points in the template, even if it's to say "NO impact". 3. **Enhance Testing Information:** Provide more specifics about the testing environment and include relevant log snippets. By addressing these points, the PR will be much clearer and easier for reviewers to evaluate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
