nuttxpr commented on PR #13990: URL: https://github.com/apache/nuttx/pull/13990#issuecomment-2402051193
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing some key information: * **Why is this change necessary?** Is there a bug? Is the current calculation incorrect for >2GB cards? * **What functional part is being changed?** Be specific - name the file(s) and functions modified. **Impact is incomplete:** * **User impact is unclear.** Will users see any difference in behavior? * **Build impact is unclear.** Will any new configurations be added? * **Hardware impact needs specifics.** *Which* ARM boards using MMC are affected? **Testing is insufficient:** * **Build Host details are missing.** What OS, compiler, etc. was used for testing? * **Target details are vague.** "Cortex M55" is a CPU architecture, not a board. Which specific board and configuration? * **Logs are placeholders.** Provide *actual* logs showing the problem before and the fix after. **In short, this PR does not meet the NuttX requirements.** It lacks crucial details about the change, its impact, and thorough testing evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
