nuttxpr commented on PR #13992: URL: https://github.com/apache/nuttx/pull/13992#issuecomment-2402086628
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why the change is necessary (fix, update, new feature). * Needs more detail on how the change works (what will change and how). "Add up_ndelay interface" is too vague. Explain what this interface does and how it is used. * **Impact:** * While you state "no impact," adding a new interface almost certainly has *some* impact. Consider: * **Documentation:** Does this new interface need to be documented? * **Compatibility:** Does this addition affect backward compatibility in any way? * **Testing:** * "ostest" is not sufficient. Please provide: * Specific build host details (OS, CPU, compiler version). * Target details (architecture, board, configuration). * **Relevant** testing logs that demonstrate the functionality before and after the change. Don't just dump entire logs – highlight the important parts. **Recommendations:** 1. **Expand the Summary:** Clearly state the purpose of adding the `up_ndelay` interface. Explain what problem it solves or what functionality it adds. 2. **Review the Impact:** Carefully consider all potential impacts. Even small changes can have ripple effects. 3. **Provide Detailed Testing Information:** Be specific about your testing environment and provide relevant logs that demonstrate the change's effect. By addressing these points, you will make your PR much stronger and easier for the NuttX maintainers to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
