XuNeo commented on code in PR #13944:
URL: https://github.com/apache/nuttx/pull/13944#discussion_r1793373639
##########
sched/group/group_argvstr.c:
##########
@@ -60,16 +61,20 @@
size_t group_argvstr(FAR struct tcb_s *tcb, FAR char *args, size_t size)
{
+ irqstate_t flags;
size_t n = 0;
#ifdef CONFIG_ARCH_ADDRENV
FAR struct addrenv_s *oldenv;
#endif
+ flags = enter_critical_section();
+
/* Sanity checks and idle tasks */
if (!tcb || !tcb->group || !tcb->group->tg_info || size < 1 ||
Review Comment:
I see. The direct access to tcb->group has been removed in [this
commit](https://github.com/apache/nuttx/pull/12320/files#diff-4c80631b4969dc86c856de89c0a424189374e6284a10a8529662f9e15e3dccd0).
Looks like we do not need `tcb->group` any more. Should I drop the PR
directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
