nuttxpr commented on PR #13999: URL: https://github.com/apache/nuttx/pull/13999#issuecomment-2402225197
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR Summary is missing crucial information: * **Why is this change necessary?** Is there a specific performance problem being addressed? * **What functional part of the code is being changed?** Mention the specific files/modules modified. * **How does the change exactly work?** Provide more detail than just "Support gprof". Explain how gprof is integrated, any data structures added, etc. **Impact Section:** * **Is new feature added?** - This seems like a YES. * **Impact on build?** - You mention enabling a config option, so this is a YES. Describe what changes in the build process when the option is enabled. * **Impact on documentation?** - YES, you'll need to document how to use this new gprof feature. **Testing Section:** * **Build Host(s):** Be specific about your build host OS and compiler version. * **Target(s):** "stm32" is not specific enough. Provide the exact board and configuration. * **Testing logs:** You need to provide actual logs before and after the change to demonstrate the functionality and any performance improvements. **In short, the PR currently lacks the necessary details and evidence to be considered complete.** To improve it, address the missing points mentioned above and provide concrete examples in the Summary, Impact, and Testing sections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
