nuttxpr commented on PR #14030: URL: https://github.com/apache/nuttx/pull/14030#issuecomment-2404136147
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why the macro definitions are necessary (fix, update, new feature). * Does not specify which functional part of the code is being changed. * Omits details about how the change works and what exactly will change. * No related issue references. * **Impact:** * While stating "no impact," it's crucial to address *all* impact categories with specifics. For instance: * **Impact on build:** Even adding macros *might* affect the build process if they introduce new dependencies or change compilation flags. * **Impact on documentation:** If these macros are user-facing, documentation would need updating. * **Testing:** * "ostest" is insufficient. Provide: * Specific build host details (OS, CPU, compiler version). * Target details (architecture, board, configuration). * Relevant snippets from testing logs demonstrating the change's effect (both before and after). **Recommendations:** 1. **Expand the Summary:** Clearly articulate the purpose and functionality of the added macros. 2. **Address All Impact Categories:** Thoroughly evaluate and describe the potential impact on all aspects, even if it seems minimal. 3. **Provide Detailed Testing Information:** Include specific host/target configurations and relevant log snippets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
