nuttxpr commented on PR #14028: URL: https://github.com/apache/nuttx/pull/14028#issuecomment-2404141051
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary provides context, explains the issue (shadowing built-in functions), and references an external example. However, it lacks crucial information: * **Missing: What functional part is changed?** Which files are modified to address the warning? Is it a simple rename or a larger refactoring? * **Missing: How the change works.** Are `static inline` declarations changed? Alternatives used? * **Impact is entirely empty.** This is critical for reviewers. **Testing is insufficient:** * **No specifics on build hosts or targets.** Saying "CI" isn't helpful without knowing the CI configurations. OS, compiler versions, target architectures are essential. * **Logs are placeholders.** Real logs demonstrating the problem *before* and the fix *after* are mandatory. **Verdict:** **This PR does NOT meet NuttX requirements.** It needs significant improvements to be considered: 1. **Complete the Summary** with specifics on code changes and how they address the issue. 2. **Fill out the Impact section thoroughly.** Consider ALL points, even if the answer is "NO" (briefly explain why). 3. **Provide REAL testing logs** showing the warning/error before and its absence after the change. Be specific about your testing environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
