pussuw commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2404569835
Sorry, I had missed this due to vacation. I think this change has a fundamental error in it; it removes the argument vector from group and moves it to the task TLS directly. This is not correct, as now pthreads / members of the group do not see the argument vector at all. Accessing process name etc. becomes impossible. I realize there was a latent bug in getprogname() but the error is that the parent's stack / TLS (or more precisely, the argument vector in the stack) is freed too soon. It should not be released until all group members have died. @yf13 can you please explain why you changed this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
