nuttxpr commented on PR #14040: URL: https://github.com/apache/nuttx/pull/14040#issuecomment-2404592992
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * **What functional part of the code is being changed?** Be specific. Which files/modules are affected? * **How does the change exactly work?** Provide a technical explanation of the changes made. * **Impact:** * While you state "no impact," this is unlikely. Even a small change can have unforeseen impacts. Consider carefully: * **Compatibility:** Could this break existing code that relies on the old behavior? * **Build:** Will any build flags or configurations need adjustments? * **Testing:** * **Insufficient Detail:** "ostest" is not descriptive enough. * **Missing Logs:** You need to provide actual testing logs from *before* and *after* your change to demonstrate the problem and the solution. * **Target Specificity:** List the specific architectures and boards you tested on. **Recommendations:** 1. **Expand the Summary:** Provide a clear and detailed explanation of the problem `__asm__()` solves, how your change addresses it, and the specific code sections affected. 2. **Thoroughly Analyze Impact:** Be comprehensive. Even seemingly minor changes can have ripple effects. 3. **Provide Detailed Testing Information:** * Include complete build host and target details. * Show actual log output demonstrating the issue before the change and the improvement after. **Remember:** A well-crafted PR increases the likelihood of it being accepted quickly. Be thorough and provide as much information as possible to help reviewers understand and evaluate your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
