nuttxpr commented on PR #14048: URL: https://github.com/apache/nuttx/pull/14048#issuecomment-2404870235
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR as described **does not meet NuttX requirements**. Here's why: * **Insufficient Detail:** The provided information is too vague. * **Summary:** * The "why" is unclear. How much performance improvement is expected? Why is `sched_lock` prone to misuse? What specific misuse scenarios are being addressed? * "What functional part" needs to be more specific than "sched." Which files/functions are modified? * "How does the change exactly work" lacks concrete examples. What code is being changed, and how does it achieve the stated goals? * **Impact:** * Saying "sched" is changed isn't enough. Which scheduling behaviors are modified? * The potential impact categories (user, build, hardware, documentation, security, compatibility) are dismissed with simple "NO" or "arm64 arm" without explanation. Each needs careful consideration and justification, even if the answer is "NO." * **Testing:** * While build instructions are provided, the testing logs are placeholders. **Actual logs demonstrating the issue before the change and the improvement after are essential.** * Testing on "other ARM hardware platforms" needs to be specified. List the exact boards and configurations used for validation. **To meet NuttX PR standards, you need to provide:** 1. **Precise and Detailed Explanations:** Be specific about the problem, the solution's mechanics, and the expected outcomes. 2. **Thorough Impact Analysis:** Justify your "NO" answers. If there's truly zero impact, explain why. 3. **Complete Testing Evidence:** Include actual logs that showcase the problem being solved and the success of the fix. 4. **Specific Platform Details:** Don't just say "other ARM platforms." Name the boards and configurations. Remember, a clear and comprehensive PR helps reviewers understand your changes, increasing the likelihood of acceptance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
