nuttxpr commented on PR #14046: URL: https://github.com/apache/nuttx/pull/14046#issuecomment-2404872783
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears **incomplete** based on the provided NuttX requirements. **Here's why:** * **Summary:** * **Missing crucial details:** * **Why is this change necessary?** Is it a fix, update, or new feature? * **What functional part of the code is being changed?** Be specific! Mentioning "gcov.sh" and "tools/gcov" is a start, but what exactly within those areas is modified? * **How does the change work?** Explain the mechanism in more detail. What does "generating device-side code coverage" mean in practical terms? * **No related issue references:** Are there any related issues in the NuttX or NuttX Apps repositories? Provide links if so. * **Impact:** * **"None" is rarely the complete answer:** While the direct user impact might be minimal, consider: * **Build Process:** Does introducing device-side code coverage impact build times or require additional tools/steps? * **Documentation:** Even if small, this feature likely needs documentation. Is it included in the PR? * **Compatibility:** Does this change affect any existing code coverage workflows? * **Testing:** * **Insufficient information:** "sim" is not descriptive enough. * **Which simulator?** (e.g., qemu-rv32, qemu-arm, etc.) * **What specific tests were run?** Provide test names or commands. * **No logs:** The "Testing logs" sections are empty. Include relevant snippets of logs demonstrating the change's behavior before and after. **To improve this PR:** 1. **Expand the Summary:** Address the missing details mentioned above. 2. **Review the Impact:** Think critically about potential side effects or changes, even if minor. 3. **Provide Specific Testing Information:** Include simulator details, test commands, and relevant log snippets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
