nuttxpr commented on PR #14054: URL: https://github.com/apache/nuttx/pull/14054#issuecomment-2404935589
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **Yes, but with minor improvements needed.** **Here's a breakdown:** * **Summary:** Well-written and clearly explains the issue (mismatched addresses in `kasan_register` and `kasan_unregister`) and its consequence (crash). * **Impact:** This section is **missing**. You need to address the impact points listed in the requirements. For example: * **Is new feature added? Is existing feature changed?** This is a bug fix, so an existing feature (likely KASAN) is being changed. * **Impact on user, build, hardware, etc.:** Describe the impact of this bug fix on each of these areas. For example, the impact on users is that a potential crash scenario is being fixed. * **Testing:** * **Build Host(s):** Specify the OS, CPU, and compiler used for testing on your local setup. * **Target(s):** "sim" is a good start, but be more specific. Which simulator? QEMU? And with what configuration? * **Testing Logs:** You haven't provided any testing logs. Include logs from before and after the change to demonstrate the problem and the fix. **Recommendations:** 1. **Complete the Impact section.** Carefully consider each point and provide specific details. 2. **Provide detailed testing information.** Include the exact build host and target configurations and provide actual testing logs. By addressing these points, your PR will better meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
