nuttxpr commented on PR #14078: URL: https://github.com/apache/nuttx/pull/14078#issuecomment-2406546729
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of *why* these changes are necessary. What problem do they solve? What is improved? * "follow the nxstyle" is too vague. Specify which nxstyle rules were violated and how they are now addressed. * **Impact:** * "rptun" is not descriptive enough. Specify which architectures, boards, or drivers are affected. * All other impact categories are simply marked "NO" without explanation. Even if there's no impact, you need to explicitly state that and briefly justify it (e.g., "Impact on build: NO - These changes are limited to the rptun driver and do not affect the build process."). * **Testing:** * "sim rpserver and rpproxy" is insufficient. Provide: * Full build host details (OS, CPU architecture, compiler version). * Specific target details (simulator used, if applicable, RISC-V/ARM architecture, board configuration). * **Actual testing logs** both before and after the change to demonstrate the problem and the fix. **Recommendations:** 1. **Expand on the Summary:** Clearly articulate the reason for the code formatting change and header file removal. What issue did these address, or what improvement do they bring? 2. **Complete the Impact Section:** Address each impact category with either a "NO" and a brief justification or a "YES" with a detailed explanation of the impact. 3. **Provide Detailed Testing Information:** Include specific details about your testing environment and the actual logs from your tests. **A well-structured PR will significantly increase the chances of it being reviewed and merged quickly.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
