nuttxpr commented on PR #14087: URL: https://github.com/apache/nuttx/pull/14087#issuecomment-2406667308
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this Pull Request does not meet the NuttX requirements.** **Here's why and how to improve it:** * **Summary:** * **Missing Details:** * **Why was the change necessary?** Explain the bug preventing SMP startup on ACRN. * **What code was changed?** Be specific – mention files, functions, or modules modified. * **How does the fix work?** Provide a technical explanation of the changes made. * **Impact:** * **Too Vague:** "No impact" is unlikely. Be explicit about which points are truly unaffected. * **Consider:** Even if the user interface doesn't change, there might be impacts on: * Performance (startup time) * Resource usage * Potential interactions with other ACRN features. * **Testing:** * **Insufficient Information:** * **Build Host:** Specify your development environment (OS, CPU, compiler version). * **Target:** Provide the ACRN version and any relevant configuration details. * **"ostest" is not descriptive:** What specific tests within `ostest` were run? Did they pass/fail before and after the fix? * **Show Evidence:** Include relevant snippets of the test logs demonstrating the problem and the fix. **Example Improvements:** ``` ## Summary * **Why:** ACRN Hypervisor experienced [describe the specific bug, e.g., deadlock, incorrect synchronization] during SMP startup due to [explain the root cause, e.g., race condition in X function]. * **What:** This patch modifies the following: * `arch/arm/src/armv8-m/up_cpu.c`: Fixed [describe the fix, e.g., synchronization issue] in the `up_cpu_start()` function. * **How:** [Provide a concise technical explanation of how your code changes solve the original problem]. ## Impact * **Is new feature added?** NO * **Is existing feature changed?** YES - SMP startup on ACRN Hypervisor. * **Impact on user:** Users running ACRN on multi-core systems will now experience successful SMP startup. * **Impact on build:** NO * **Impact on hardware:** Specific to systems running the ACRN Hypervisor. * **Impact on documentation:** NO * **Impact on security:** NO * **Impact on compatibility:** NO * **Anything else to consider:** N/A ## Testing **Build Host:** Ubuntu 20.04, Intel Core i7-XXXX, GCC 9.4.0 **Target:** ACRN Hypervisor v[version], [Board/Configuration if relevant] **Testing logs before change:** ``` [Relevant log snippet showing the SMP startup failure] ``` **Testing logs after change:** ``` [Relevant log snippet showing successful SMP startup] ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
