nuttxpr commented on PR #14084: URL: https://github.com/apache/nuttx/pull/14084#issuecomment-2406669133
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing some key information: * **Why is the change necessary?** Simply stating "ostest FPU test will fail" is not descriptive enough. Explain why the optimization causes the failure (as you did in the detailed explanation). * **What functional part of the code is being changed?** Mention that the change involves adding a compiler flag to the build system for the ostest. * **How does the change exactly work?** Briefly state that the change disables tree vectorization during compilation to prevent the issue. **Impact:** * **Impact on the build:** The PR states "no impact" but adding a compiler flag *does* impact the build process, even if minimally. Be explicit and mention that the flag `-fno-tree-vectorize` is added to the build. **Testing:** * **Insufficient details:** The testing section only mentions "ostest." Specify: * The build host OS, CPU architecture, and compiler used. * The target architecture and board configuration. * Provide snippets of the relevant log output before and after the change, demonstrating the FPU test failure and subsequent fix. **Verdict:** The PR, as described, **does not meet the NuttX requirements**. It needs more details and clarity in the Summary, Impact, and Testing sections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
