nuttxpr commented on PR #14089: URL: https://github.com/apache/nuttx/pull/14089#issuecomment-2406694421
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The provided PR description lacks sufficient information to determine if it meets NuttX requirements. Here's a breakdown: **What's Missing & Why It's Important:** * **Summary:** * **Vague Description:** "sched_lock is time-consuming" is not specific enough. What code uses it excessively? How is the scope narrowed? Concrete examples are crucial. * **Missing Technical Details:** How does the change *exactly* work? Code examples or a clear explanation of the modification are needed. * **No Issue References:** Linking to related issues helps reviewers understand the context and prior discussions. * **Impact:** * **All sections are empty!** This is the most critical part. Reviewers need to understand the potential consequences of this PR: * **User Impact:** Will applications break? Do configurations need changes? * **Build Impact:** Are new dependencies introduced? Do build flags change? * **Hardware Impact:** Are specific architectures or boards affected? * **Security Impact:** Could this change introduce vulnerabilities? * **Compatibility:** Will older applications or kernels still work? * **Testing:** * **Build Hosts:** List *all* operating systems, CPUs, and compilers used for testing. * **Targets:** Be specific about the boards and configurations tested beyond "other ARM platforms." * **Logs:** The provided logs are placeholders. Include *actual* logs demonstrating the issue before the change and the improvement afterward. **How to Improve:** 1. **Be Specific:** Use concrete examples, code snippets, and clear explanations. 2. **Address All Impact Points:** Even if the answer is "NO", briefly explain why. 3. **Provide Real Test Data:** Logs should demonstrate the problem being solved and the effectiveness of the solution. **Example for "Impact" (assuming no user-facing changes):** ``` ## Impact * Is new feature added? Is existing feature changed? NO - This optimizes existing code. * Impact on user (will user need to adapt to change)? NO - Internal change, no user impact expected. * Impact on build (will build process change)? NO - No new dependencies or build flags. * Impact on hardware (will arch(s) / board(s) / driver(s) change)? NO - Change is architecture-agnostic. * Impact on documentation (is update required / provided)? MAYBE - If the usage of `sched_lock` is now restricted, documentation should reflect this. * Impact on security (any sort of implications)? NO - Performance improvement, no security implications anticipated. * Impact on compatibility (backward/forward/interoperability)? NO - Existing applications should continue to function as before. * Anything else to consider? N/A ``` By addressing these points, you'll significantly increase the chances of your PR being reviewed and merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
