nuttxpr commented on PR #2683: URL: https://github.com/apache/nuttx-apps/pull/2683#issuecomment-2406866738
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirements Review **Verdict:** The PR summary is insufficient. Testing information is inadequate. **Details:** * **Summary:** * **Missing:** You must describe HOW the change works. * Where is the lsan command implemented? * How is it invoked? * What are the options? * What output does it provide? * **Impact:** * **New Feature:** While technically correct, you should elaborate on what the LeakSanitizer tool offers. Briefly explain its purpose and benefits for users. * **Documentation:** Does this new feature require documentation updates? If so, are they included in the PR? * **Testing:** * **Insufficient:** "sim" is not descriptive enough. * Which simulator? * What specific tests were run? * **Logs:** You must provide BEFORE and AFTER testing logs to demonstrate the change's effect. **Recommendation:** Expand the summary to thoroughly explain the implementation. Provide specific details for the "Impact" sections where applicable. Include detailed testing information with relevant logs showcasing the functionality before and after the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
