nuttxpr commented on PR #14107: URL: https://github.com/apache/nuttx/pull/14107#issuecomment-2406922400
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to **partially meet** the NuttX requirements. **Here's why:** * **Summary:** While it explains the "what" (adding a config option and changing log APIs), it lacks a clear explanation of the "why." What specific problem does the excessive logging from `irqinfo()` cause? * **Impact:** * It mentions "ARMV7A GIC Debug Dump" but doesn't explain what this is or how it's impacted. * It needs to address **all** impact points (build, hardware, documentation, security, compatibility) with "NO" or a description if "YES." * **Testing:** * It provides minimal information. * Specify the **OS**, **compiler**, and **versions** used for the build host. * For the target, specify the **specific board** and **configuration** used. * Include **actual testing logs** before and after the change to demonstrate the issue and the fix. **To fully meet the requirements, the PR needs:** 1. **Expanded Summary:** Explain the reason behind needing a separate config option for GIC dump and why changing the log API is necessary. 2. **Detailed Impact:** Address all impact categories with either "NO" or a clear explanation of the impact. 3. **Comprehensive Testing:** Provide detailed information about the build host, target environment, and actual testing logs. By addressing these points, the PR will be clearer and easier for reviewers to assess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
