anchao commented on code in PR #14083: URL: https://github.com/apache/nuttx/pull/14083#discussion_r1797510016
########## sched/sched/sched_suspendscheduler.c: ########## @@ -63,7 +63,7 @@ void nxsched_suspend_scheduler(FAR struct tcb_s *tcb) { /* Handle the task exiting case */ - if (tcb != NULL) + if (tcb == NULL) Review Comment: It is impossible for the caller of this function to pass an invalid tcb, right? let us remove this check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org