davids5 commented on a change in pull request #1311:
URL: https://github.com/apache/incubator-nuttx/pull/1311#discussion_r447224067
##########
File path: include/sys/types.h
##########
@@ -104,17 +105,6 @@
#ifndef __ASSEMBLY__
-/* Floating point types */
Review comment:
@xiaoxiang781216 I am running into problems with this change. It looks
like we require now CONFIG_LIBM needs to be set to get the followinf removed
from sys/types.h and moved to include/nuttx/lib/math.h
```
typedef float float32;
#ifndef CONFIG_HAVE_DOUBLE
typedef float double_t;
typedef float float64;
#else
typedef double double_t;
typedef double float64;
#endif
```
But if we do set CONFIG_LIBM we loose things like `fmaxf` from the
toolchain headers that do not define the moved types . Can you offer your
motivation for this change and suggest how we are expected to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
