nuttxpr commented on PR #14142: URL: https://github.com/apache/nuttx/pull/14142#issuecomment-2408405686
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing crucial information like: * **Reason for change:** Is it a bug fix, optimization, or a new feature? This is essential for reviewers. * **Functional change description:** Simply stating "Openlibm adds exp10 and exp10f function implementations" is insufficient. Explain what these functions do and how they are implemented. Mention if any algorithms or data structures were used. * **References:** Are there any related issues in the NuttX or NuttX Apps repositories? Linking them provides context. The impact section is overly brief. While "no impact" might be true for some aspects, you should consider and explicitly address: * **User impact:** Will users need to change their code or configuration? Even if the answer is no, state it explicitly. * **Documentation impact:** Does this change require documentation updates? If so, have you updated the documentation? The testing section lacks detail: * **Host details:** Specify the OS, CPU architecture, and compiler version used for building. * **Target details:** Provide information about the target architecture, board, and configuration used for testing. * **Testing logs:** Instead of just "ostest", include relevant snippets of logs from before and after the change. This helps demonstrate the change's effect. **In conclusion, this PR does not meet the NuttX requirements in its current form.** You need to provide more context and details in the Summary, Impact, and Testing sections. Refer to the contributing guidelines for specific examples and formatting suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
