nuttxpr commented on PR #14143: URL: https://github.com/apache/nuttx/pull/14143#issuecomment-2408410838
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX Requirements.** **Here's why and how to fix it:** **Summary:** * **Missing Why:** You list what boards are added but not *why* these boards are being added or what functionality they provide. What problem does this solve? What new capabilities do these boards bring to NuttX? * **Missing How:** You mention adding CMake builds, but not *how* these builds are structured. Do they use any special configurations? Are there any dependencies on other parts of the NuttX codebase? * **Issues/PR References:** Are there any related issues or pull requests in either the NuttX or NuttX Apps repositories? If so, provide links to them. * **Comment Fix: ** Be more specific. What comments were fixed? Why were they incorrect, and how were they improved? **Impact:** * **All sections are blank.** You need to thoroughly address each impact category: * **Feature:** Are you adding a new feature or changing an existing one? * **User Impact:** Will users need to change their workflow or configuration? If so, how? * **Build Impact:** Will the NuttX build system need any modifications? Are there new build options? * **Hardware Impact:** Be specific about the architectures, boards, and drivers affected. * **Documentation:** If this PR introduces new features or changes existing ones, you'll need to update the documentation. State whether documentation updates are included in this PR. * **Security/Compatibility:** Even if there are no impacts, you should explicitly state "NO" and briefly explain why. **Testing:** * **Provide Details:** Specify the *exact* build hosts (OS, CPU, compiler versions) and targets (architecture, board, configuration) you used for testing. * **Include Logs:** Paste the relevant portions of your testing logs both before and after the changes. The logs should demonstrate that the new boards can be built successfully and function as expected. **Additional Tips:** * **Conciseness:** While the provided template is a good starting point, aim for a balance between conciseness and completeness. * **Clarity:** Use clear and straightforward language. Avoid technical jargon that might not be familiar to all reviewers. * **Correctness:** Double-check all information for accuracy before submitting the PR. By addressing these points, your PR will be more likely to be reviewed and merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
