nuttxpr commented on PR #14162: URL: https://github.com/apache/nuttx/pull/14162#issuecomment-2408442060
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why the change is necessary. Is it a bug fix, performance improvement, or new feature? * Needs more detail on what "common implementation" refers to and how the change works. * **Impact:** * While it mentions "qemu armv7a virtio mmio devices," it doesn't explain if this is a new feature, a change to an existing feature, or a bug fix. * The impact sections (user, build, hardware, documentation, security, compatibility) are not adequately addressed. A simple "NO" or a list of affected areas is not enough. Provide specific details about the impact (or lack thereof) in each area. * **Testing:** * Lacks specific details about the build host and target environments. * No testing logs are provided to demonstrate the issue before the change and the functionality after the change. **To meet the NuttX PR requirements, you need to:** 1. **Expand the Summary:** * Clearly state the purpose of the change (bug fix, improvement, new feature). * Explain what the "common implementation" is and how it's being used. * Provide a concise overview of the code changes. 2. **Detail the Impact:** * For each impact area (user, build, hardware, documentation, security, compatibility), explain if there is an impact. * If there's no impact, state it explicitly (e.g., "Impact on build: NO - The build process remains unchanged."). * If there is an impact, describe it thoroughly. For example: * **User:** "Users will now need to use the new API function 'xyz' to register MMIO devices. The old method is deprecated." * **Hardware:** "This change adds support for the 'ABC' sensor on the 'XYZ' board." 3. **Provide Thorough Testing Information:** * **Build Host(s):** Specify the operating system, CPU architecture, and compiler used (e.g., "Linux, x86_64, GCC 9.4.0"). * **Target(s):** Specify the architecture, board, and configuration used for testing (e.g., "ARMv7-A, STM32F4 Discovery, default configuration"). * **Testing Logs:** Include relevant logs that show: * The issue or behavior before the change. * The corrected behavior or new functionality after the change. By providing this level of detail, your PR will be much easier for the NuttX maintainers to understand, review, and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
